Skip to content

Conversation

@claire-lovisa
Copy link
Contributor

There is no need to escape single quotes in URIs, which can cause errors then in virtuoso when inserting espaces ', but there is the need to escape < and > to avoid injections.

@MikiDi
Copy link
Contributor

MikiDi commented Nov 24, 2021

For reference: This has recently been adapted in the ruby template as well. Not the escaping of the angle brackets though ...

@erikap
Copy link
Member

erikap commented Nov 26, 2021

Thanks for the fix @claire-lovisa 🙏 We're looking for a strategy to sync the behaviour of the escape-helper across all templates. Progress is tracked in mu-semtech/project#2

@cecemel cecemel merged commit e9310d4 into mu-semtech:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants